Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: runtime pallet order #662

Merged
merged 1 commit into from
May 16, 2024
Merged

fix: runtime pallet order #662

merged 1 commit into from
May 16, 2024

Conversation

enthusiastmartin
Copy link
Contributor

No description provided.

@github-actions GitHub Actions
Copy link

Crate versions that have been updated:

  • basilisk-runtime: v114.0.0 -> v115.0.0

Runtime version has been increased.

Roznovjak
Roznovjak reviewed May 15, 2024
View reviewed changes
Copy link
Collaborator

@Roznovjak Roznovjak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also update the order of on_initialize/finalize in integration_tests/polkadot_test_net.rs

@enthusiastmartin
Copy link
Contributor Author

Please also update the order of on_initialize/finalize in integration_tests/polkadot_test_net.rs

this does not apply to basilisk. there is not a particular place where we can on_initialize.

@enthusiastmartin enthusiastmartin merged commit 8659a76 into master May 16, 2024
4 checks passed
@enthusiastmartin enthusiastmartin deleted the runtime-pallet-order branch May 16, 2024 07:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Roznovjak Roznovjak Roznovjak left review comments

@mrq1911 mrq1911 mrq1911 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@enthusiastmartin @mrq1911 @Roznovjak