Support Unity 6 #245
Merged
Support Unity 6 #245
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
https://github.com/game-ci/docker/actions/runs/8976709291/job/24654170123?pr=245
Details
Is it because it didn't use the latest version of test runner? the pipeline errors seems related to game-ci/unity-test-runner#264 (comment) |
GabLeRoux
approved these changes
May 7, 2024
There was a problem hiding this comment.
I've skipped most of the generated files / node_modules files in my review. The regex seem fine to me. I'm not too confident about the changes about JAVA and ANDROID related env vars but I assume these are also good changes (namely 'Fix Android variables for Unity 2021+').
This looks good to me. I've identified something about the pipeline and test runner with unity 6, but other than that, this change looks good to me so far 🚀
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Checklist