-
-
Notifications
You must be signed in to change notification settings - Fork 119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
V3 Docs Update #384
V3 Docs Update #384
Conversation
Visit the preview URL for this PR (updated for commit 48086a4): https://game-ci-5559f--pr384-v3-docs-od7w2su2.web.app (expires Wed, 05 Apr 2023 03:54:31 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 1f0574f15f83e11bfc148eae8646486a6d0e078b |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Your description is missing why we're moving from version 2 to 3.
Do we really need to bump versions already if all we're doing is removing a deprecated parameter?
If the changes are largely in cloud-runner I'd suggest sticking with v2.x until we have actual breaking changes in our public interface.
current: { | ||
label: 'v2 (current)', | ||
label: 'v3 (current)', | ||
}, | ||
1: { | ||
label: 'v1', | ||
}, | ||
2: { | ||
label: 'v2', | ||
}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#### androidAppBundle | ||
|
||
**[Deprecated] Please use androidExportType instead.** | ||
|
||
Set this flag to `true` to build '.aab' instead of '.apk'. | ||
|
||
```yaml | ||
- uses: game-ci/unity-builder@v2 | ||
with: | ||
androidAppBundle: true | ||
androidKeystoreName: user.keystore | ||
androidKeystoreBase64: ${{ secrets.ANDROID_KEYSTORE_BASE64 }} | ||
androidKeystorePass: ${{ secrets.ANDROID_KEYSTORE_PASS }} | ||
androidKeyaliasName: ${{ secrets.ANDROID_KEYALIAS_NAME }} | ||
androidKeyaliasPass: ${{ secrets.ANDROID_KEYALIAS_PASS }} | ||
``` | ||
|
||
You should also set all the Android Keystore options (see below). Refer to (this | ||
section)[/docs/github/deployment/android#3-generate-an-upload-key-and-keystore] for keystore setup. | ||
|
||
_**required:** `false`_ _**default:** `false`_ | ||
**[Removed in V3] Please use androidExportType instead.** |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lets not document removed properties.
@AndrewKahr is this PR still needed, or did you port over all changes to #407? |
I ported it over, closing this. |
Changes
Checklist
code of conduct