Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix pro activation #602

Merged
merged 5 commits into from
Nov 28, 2023
Merged

Fix pro activation #602

merged 5 commits into from
Nov 28, 2023

Conversation

AndrewKahr
Copy link
Member

@AndrewKahr AndrewKahr commented Nov 25, 2023

Changes

  • Only randomize uuid for personal licenses
  • Add warning annotation for license activation retries
  • add engineExitCode output
  • repo/code cleanup

Related Issues

Related PRs

Checklist

  • Read the contribution guide and accept the
    code of conduct
  • Docs (If new inputs or outputs have been added or changes to behavior that should be documented. Please make a PR
    in the documentation repo)
  • Readme (updated or not needed)
  • Tests (added, updated or not needed)

Copy link

Cat Gif

@codecov-commenter
Copy link

codecov-commenter commented Nov 25, 2023

Codecov Report

Merging #602 (4169688) into main (96cfb84) will increase coverage by 0.10%.
The diff coverage is 10.00%.

❗ Current head 4169688 differs from pull request most recent head 9413908. Consider uploading reports for the commit 9413908 to get more accurate results

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #602      +/-   ##
==========================================
+ Coverage   37.33%   37.43%   +0.10%     
==========================================
  Files          76       75       -1     
  Lines        3059     3045      -14     
  Branches      611      604       -7     
==========================================
- Hits         1142     1140       -2     
+ Misses       1917     1905      -12     
Files Coverage Δ
src/model/output.ts 75.00% <0.00%> (-25.00%) ⬇️
src/model/cloud-runner/providers/docker/index.ts 16.36% <0.00%> (-0.62%) ⬇️
src/model/docker.ts 11.36% <20.00%> (+0.72%) ⬆️

Copy link
Member

@webbertakken webbertakken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

src/model/output.ts Outdated Show resolved Hide resolved
src/index.ts Outdated Show resolved Hide resolved
@AndrewKahr AndrewKahr merged commit bbd713b into main Nov 28, 2023
39 checks passed
@AndrewKahr AndrewKahr deleted the fix-pro-activation branch November 28, 2023 07:24
@GabLeRoux
Copy link
Member

🎉 awesome, thanks for the updates!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants