Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hotfix: Fix version checking in image-tag #640

Merged
merged 2 commits into from
Mar 17, 2024

Conversation

AndrewKahr
Copy link
Member

@AndrewKahr AndrewKahr commented Mar 17, 2024

Changes

  • Update version checking in image-tag.ts to support 6000+ Unity versions.

Checklist

  • Read the contribution guide and accept the
    code of conduct
  • Docs (If new inputs or outputs have been added or changes to behavior that should be documented. Please make a PR
    in the documentation repo)
  • Readme (updated or not needed)
  • Tests (added, updated or not needed)

Copy link

Cat Gif

@codecov-commenter
Copy link

codecov-commenter commented Mar 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 36.97%. Comparing base (0c16aab) to head (9b7bf61).

❗ Current head 9b7bf61 differs from pull request most recent head 84b41f7. Consider uploading reports for the commit 84b41f7 to get more accurate results

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #640   +/-   ##
=======================================
  Coverage   36.97%   36.97%           
=======================================
  Files          77       77           
  Lines        3121     3121           
  Branches      645      645           
=======================================
  Hits         1154     1154           
  Misses       1824     1824           
  Partials      143      143           
Files Coverage Δ
src/model/image-tag.ts 49.45% <100.00%> (ø)

@webbertakken
Copy link
Member

Not sure I agree with the reasoning on this one. Just because they add a new version scheme that's actually not so very different doesn't meant we have to make logic more implicit and call it out of scope. In the other PRs, we also still use a regex. The argument "if they change things again" is generally not a great one in software development either.

I'd prefer to keep specific rather than implicit and not architecting for things that might never be.

@AndrewKahr AndrewKahr changed the title Hotfix: Remove version checking from image-tag Hotfix: Fix version checking in image-tag Mar 17, 2024
@AndrewKahr AndrewKahr merged commit dd42746 into main Mar 17, 2024
51 checks passed
@AndrewKahr AndrewKahr deleted the hotfix-new-unity-version-issues branch March 17, 2024 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants