Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix error handling #1034

Merged
merged 1 commit into from
Aug 22, 2024
Merged

Fix error handling #1034

merged 1 commit into from
Aug 22, 2024

Conversation

hebelsan
Copy link
Contributor

How to categorize this PR?

/area quality
/kind bug
/platform aws

What this PR does / why we need it:
Return error instead of nil in function CleanupTerraformerResources

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Release note:

Fix error handling in terraformer cleanup resources function

@hebelsan hebelsan requested review from a team as code owners August 22, 2024 10:23
@gardener-robot gardener-robot added needs/review Needs review area/quality Output qualification (tests, checks, scans, automation in general, etc.) related kind/bug Bug platform/aws Amazon web services platform/infrastructure size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) labels Aug 22, 2024
@gardener-robot-ci-1 gardener-robot-ci-1 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Aug 22, 2024
@hebelsan hebelsan merged commit 2b5725e into gardener:master Aug 22, 2024
16 checks passed
@hebelsan hebelsan deleted the fix-cleanup branch August 22, 2024 11:03
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label Aug 22, 2024
@kon-angelo kon-angelo mentioned this pull request Aug 29, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AndreasBurger AndreasBurger AndreasBurger approved these changes

Assignees
No one assigned
Labels
area/quality Output qualification (tests, checks, scans, automation in general, etc.) related kind/bug Bug needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/review Needs review platform/aws Amazon web services platform/infrastructure size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@hebelsan @AndreasBurger @gardener-robot-ci-1 @gardener-robot