Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

node/npm screenshot version update #10612

Closed
wants to merge 1 commit into from
Closed

node/npm screenshot version update #10612

wants to merge 1 commit into from

Conversation

NoriSte
Copy link
Contributor

@NoriSte NoriSte commented Dec 21, 2018

Description

A colleague of mine has been led to the error from the version shown in the old screenshot. With the versions of the old screenshot, the installation fails

Related Issues

I fixed all my own the issue but if you'd like to have a detailed description... below you can find the steps to reproduce the issue that make me submit this PR

$ node --version
v8.11.1 # it happens with v8.11.3 too
$ mkdir gastby
$ cd gatsby
$ npx gatsby new gatsby-site
$ cd gatsby-site
$ yarn gatsby develop

success open and validate gatsby-configs — 0.006 s
success load plugins — 0.163 s
success onPreInit — 0.479 s
success delete html and css files from previous builds — 0.078 s
success initialize cache — 0.007 s
success copy gatsby files — 0.045 s
success onPreBootstrap — 0.003 s
success source and transform nodes — 0.046 s
success building schema — 0.236 s
success createPages — 0.000 s
success createPagesStatefully — 0.036 s
success onPreExtractQueries — 0.005 s
success update schema — 0.116 s
success extract queries from components — 0.104 s
error UNHANDLED EXCEPTION


  TypeError: queue.off is not a function
  
  - page-query-runner.js:162 Queue.onDrain
    [gatsby-site]/[gatsby]/dist/internal-plugins/query-runner/page-query-runner.js:162:13
  
  - queue.js:469 Queue._drained
    [gatsby-site]/[better-queue]/lib/queue.js:469:8
  
  - queue.js:505 Queue._processNextIfAllowed
    [gatsby-site]/[better-queue]/lib/queue.js:505:14
  
  - queue.js:489 Timeout._onTimeout
    [gatsby-site]/[better-queue]/lib/queue.js:489:12
  

error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

Environment

System:
    OS: macOS High Sierra 10.13.6
    CPU: (8) x64 Intel(R) Core(TM) i7-4770HQ CPU @ 2.20GHz
    Shell: 3.2.57 - /bin/bash
  Binaries:
    Node: 8.11.1 - /usr/local/bin/node
    Yarn: 1.9.2 - /usr/local/bin/yarn
    npm: 5.6.0 - /usr/local/bin/npm
  npmPackages:
    gatsby: ^2.0.53 => 2.0.74 
    gatsby-image: ^2.0.20 => 2.0.25 
    gatsby-plugin-manifest: ^2.0.9 => 2.0.12 
    gatsby-plugin-offline: ^2.0.16 => 2.0.20 
    gatsby-plugin-react-helmet: ^3.0.2 => 3.0.5 
    gatsby-plugin-sharp: ^2.0.14 => 2.0.16 
    gatsby-source-filesystem: ^2.0.8 => 2.0.12 
    gatsby-transformer-sharp: ^2.1.8 => 2.1.9 

A colleague of mine has been led to the error from the version shown in the old screenshot. With the versions of the old screenshot, the installation fails
@NoriSte NoriSte requested a review from a team December 21, 2018 14:53
@jameswlane
Copy link

jameswlane commented Dec 21, 2018

I am seeing the same error currently and have been trying to resolve it all morning.

By moving from Node 8 to Node 10, it resolved my issue.

@DSchau
Copy link
Contributor

DSchau commented Dec 21, 2018

Our Appveyor builds are also failing with the same error; so this seems to be some issue with one of our dependencies in that particular node version, correct?

https://ci.appveyor.com/project/KyleAMathews/gatsby/builds/21176198/job/31arqy7c3y238xf5

@DSchau
Copy link
Contributor

DSchau commented Dec 21, 2018

This possibly was introduced with #10593 so it could be worth investigating that further.

DSchau pushed a commit that referenced this pull request Dec 21, 2018
<!--
  Have any questions? Check out the contributing docs at https://gatsby.app/contribute, or
  ask in this Pull Request and a Gatsby maintainer will be happy to help :)
-->

## Description

<!-- Write a brief description of the changes introduced by this PR -->
This fixes a bug introduced in #10593 by replacing the `.off` call with `.removeListener`. `.off` was introduced in Node v10.0.0 as an alias for `.removeListener` (nodejs/node#17156).

## Related Issues

<!--
  Link to the issue that is fixed by this PR (if there is one)
  e.g. Fixes #1234, Addresses #1234, Related to #1234, etc.
-->
Related to #10612
@DSchau
Copy link
Contributor

DSchau commented Dec 21, 2018

The underlying issue was closed out in #10613, so going to close this out.

Please re-open if you think this is a mistake or if we can help out further.

Thanks again!

@DSchau DSchau closed this Dec 21, 2018
gpetrioli pushed a commit to gpetrioli/gatsby that referenced this pull request Jan 22, 2019
<!--
  Have any questions? Check out the contributing docs at https://gatsby.app/contribute, or
  ask in this Pull Request and a Gatsby maintainer will be happy to help :)
-->

## Description

<!-- Write a brief description of the changes introduced by this PR -->
This fixes a bug introduced in gatsbyjs#10593 by replacing the `.off` call with `.removeListener`. `.off` was introduced in Node v10.0.0 as an alias for `.removeListener` (nodejs/node#17156).

## Related Issues

<!--
  Link to the issue that is fixed by this PR (if there is one)
  e.g. Fixes gatsbyjs#1234, Addresses gatsbyjs#1234, Related to gatsbyjs#1234, etc.
-->
Related to gatsbyjs#10612
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants