Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(redirects): handle absolute from paths when path prefix is used #12509

Merged
merged 3 commits into from
Mar 13, 2019
Merged

feat(redirects): handle absolute from paths when path prefix is used #12509

merged 3 commits into from
Mar 13, 2019

Conversation

edykim
Copy link
Contributor

@edykim edykim commented Mar 12, 2019

Description

toPath in createRedirect handles path prefix properly, however, fromPath doesn't. I added the code for supporting the fromPath cases.

Also, I added test cases of createRedirect action for the future.

Related Issues

Fixes #12497

@edykim edykim requested a review from a team as a code owner March 12, 2019 07:31
pieh
pieh reviewed Mar 12, 2019
View reviewed changes
Copy link
Contributor

@pieh pieh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking very nice! I really love comprehensive test suite for this! I have one suggestion just to keep code a little more DRY

packages/gatsby/src/redux/actions.js Outdated Show resolved Hide resolved
packages/gatsby/src/redux/__tests__/redirects.js Outdated Show resolved Hide resolved
@edykim
Remove unnecessary use strict
8408cb6
@edykim
Refactor createRedirect
3e4fd23 
Remove duplicated logic and make it as maybeAddPathPrefix.
@edykim
Copy link
Contributor Author

edykim commented Mar 12, 2019 •
edited
Loading

@pieh Thanks for the thoughtful review. I updated the code based on your recommendation. Please review the changes when you have time. 😊

@edykim edykim requested a review from pieh March 13, 2019 06:52
@pieh pieh changed the title Handle path prefix on fromPath in createRedirect feat(redirects): handle absolute from paths when path prefix is used Mar 13, 2019
pieh
pieh approved these changes Mar 13, 2019
View reviewed changes
Copy link
Contributor

@pieh pieh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! thanks @edykim!

@pieh pieh merged commit c6583d4 into gatsbyjs:master Mar 13, 2019
@edykim edykim deleted the topics/gatsby-actions-create-redirect branch March 13, 2019 18:32
This was referenced Nov 18, 2020
Open
Open
This was referenced Dec 17, 2020
Open
Open
This was referenced Mar 31, 2021
Open
Open
This was referenced May 25, 2021
Open
Open
Open
Open
This was referenced Sep 16, 2021
Open
Open
This was referenced Dec 1, 2021
Open
Open
@snyk-bot snyk-bot mentioned this pull request Jan 20, 2022
Open
@snyk-bot snyk-bot mentioned this pull request Feb 2, 2022
Open
@snyk-bot snyk-bot mentioned this pull request Mar 27, 2022
Open
@saurabharch saurabharch mentioned this pull request May 5, 2022
Open
@saurabharch saurabharch mentioned this pull request Jun 19, 2022
Open
@snyk-bot snyk-bot mentioned this pull request Jun 21, 2022
Open
@snyk-bot snyk-bot mentioned this pull request Feb 6, 2023
Open
@ajesse11x ajesse11x mentioned this pull request Mar 24, 2023
Open
@saurabharch saurabharch mentioned this pull request Jun 24, 2023
Open
This was referenced Jun 24, 2023
Open
Open
@saurabharch saurabharch mentioned this pull request Jun 30, 2023
Open
@ajesse11x ajesse11x mentioned this pull request Jul 4, 2023
Open
@saurabharch saurabharch mentioned this pull request Jul 12, 2023
Open
@ajesse11x ajesse11x mentioned this pull request Aug 6, 2023
Open
This was referenced Nov 28, 2023
Open
Open
@saurabharch saurabharch mentioned this pull request Dec 7, 2023
Open
This was referenced Jan 5, 2024
Open
Open
@ajesse11x ajesse11x mentioned this pull request Jan 13, 2024
Open
@saurabharch saurabharch mentioned this pull request Jan 17, 2024
Open
@ajesse11x ajesse11x mentioned this pull request May 16, 2024
Open
@saurabharch saurabharch mentioned this pull request May 16, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pieh pieh pieh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

createRedirect from other domain conflicts with pathPrefix
2 participants
@edykim @pieh