refactor(gatsby): use virtual modules for (a)sync-requires and match-paths.json
#25057
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gatsbot
bot
added
the
status: triage needed
pieh
added
topic: webpack/babel
| instances.forEach(instance => { | ||
| instance.writeModule(adjustedFilePath, fileContents) | ||
| }) | ||
| } |
There was a problem hiding this comment.
This is really cool. i would love to have a header comment explaining what this module can do so in the future when a dev is reading this can know in what cases they might want to reuse this!
There was a problem hiding this comment.
Will add some description/context, good point
blainekasten
previously approved these changes
Jun 17, 2020
pieh
force-pushed
the
webpack/virtual-modules
branch
2 times, most recently
from
4c1696e
to
ca13d28
Compare
pieh
force-pushed
the
webpack/virtual-modules
branch
2 times, most recently
from
388f7fa
to
d8a49e3
Compare
wardpeet
suggested changes
Jun 20, 2020
pieh
force-pushed
the
webpack/virtual-modules
branch
from
d8a49e3
to
c3c0302
Compare
wardpeet
previously approved these changes
Jun 25, 2020
pieh
force-pushed
the
webpack/virtual-modules
branch
3 times, most recently
from
9e32e72
to
1425b55
Compare
pieh
force-pushed
the
webpack/virtual-modules
branch
from
c4b0297
to
56d2938
Compare
|
Your pull request can be previewed in Gatsby Cloud: https://build-32835a8f-a9e9-43fb-817d-78742faf3c08.staging-previews.gtsb.io |
wardpeet
approved these changes
Jul 3, 2020
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This avoids adding
fsinvolved when we dynamically generate(a)sync-requiresandmatch-paths.jsonfiles.Why using
fsis problematic?It adds unnecessary async code to the pipeline, writing is fine (in fact I don't remove writing in this PR - see comment in
requires-writer.tsfor reaosns). It's about when we (or rather webpack watching) react to fs changes events - webpack watcher have some debounced/aggregation logic (200ms afaik) + any system level delays (from writing to fs, to receiving FS change event in watchpack/chokidar).This PR on its own is not solving lot of problems, but it makes it easier for future PRs that try to coordinate our services to avoid pitfalls of some debounced state transitions
[CH9862]