Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(gatsby): Always render the body component to ensure needed head & pre/post body components are added #29077

Merged
merged 2 commits into from
Jan 18, 2021

Conversation

KyleAMathews
Copy link
Contributor

@KyleAMathews KyleAMathews commented Jan 18, 2021

For client-only pages, we just want to render an empty body but we do want the other components rendered.

Fixes problem raised by @martinhj and verified in @nikoladev's reproduction #28138 (reply in thread)

… pre/post body components are added

For client-only pages, we just want to render an empty body but we do want the other components rendered
@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Jan 18, 2021
@vladar vladar added bot: merge on green Gatsbot will merge these PRs automatically when all tests passes and removed status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer labels Jan 18, 2021
@gatsbybot gatsbybot merged commit e998870 into master Jan 18, 2021
@gatsbybot gatsbybot deleted the dev-ssr-styles branch January 18, 2021 18:19
This was referenced Jan 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot: merge on green Gatsbot will merge these PRs automatically when all tests passes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants