Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: query on demand loading indicator always active on preact. #29829

Merged
merged 1 commit into from
Feb 28, 2021

Conversation

chrsep
Copy link
Contributor

@chrsep chrsep commented Feb 28, 2021

Description

This PR fixes the query on-demand loading indicator always being active when using gatsby with preact.
image

This is caused by preact not rendering attributes with a literal bool false value. Turning the bool value into a string before passing it to preact solved the issue.

Related Issues

Fixes #29051

@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Feb 28, 2021
@chrsep chrsep force-pushed the fix/preact-loading-indicator branch from db0f116 to cb332a8 Compare February 28, 2021 07:30
Copy link
Contributor

@wardpeet wardpeet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice find! this works great. Thank you for fixing this!

@wardpeet wardpeet merged commit fa1e2d6 into gatsbyjs:master Feb 28, 2021
@wardpeet wardpeet added topic: preact* and removed status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer labels Feb 28, 2021
vladar pushed a commit that referenced this pull request Feb 28, 2021
vladar pushed a commit that referenced this pull request Feb 28, 2021
…) (#29836)

(cherry picked from commit fa1e2d6)

Co-authored-by: Chrisando Pramudhita <chrisep8@gmail.com>
ascorbic pushed a commit that referenced this pull request Mar 1, 2021
ascorbic pushed a commit that referenced this pull request Mar 1, 2021
…) (#29882)

(cherry picked from commit fa1e2d6)

Co-authored-by: Chrisando Pramudhita <chrisep8@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[gatsby-plugin-preact]: Query on Demand, loading indicator always active
2 participants