Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(create-gatsby): Respect telemetry disable #34495

Merged
merged 6 commits into from
Jan 17, 2022
Merged

fix(create-gatsby): Respect telemetry disable #34495

merged 6 commits into from
Jan 17, 2022

Conversation

tyhopp
Copy link
Contributor

@tyhopp tyhopp commented Jan 14, 2022 •
edited by LekoArts
Loading

Description

Ensure create-gatsby respects user-provided environment variable to disable telemetry.

Related Issues

@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Jan 14, 2022
@tyhopp tyhopp marked this pull request as draft January 14, 2022 10:43
@tyhopp tyhopp added topic: cli Related to the Gatsby CLI type: bug An issue or pull request relating to a bug in Gatsby and removed status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer labels Jan 14, 2022
@tyhopp tyhopp linked an issue Jan 14, 2022 that may be closed by this pull request
Impossible to disable telemetry for the CLI #34486
Closed
2 tasks
@tyhopp tyhopp force-pushed the fix-create-gatsby-telemetry branch from fd990b4 to 9b8c8de Compare January 17, 2022 04:36
@tyhopp tyhopp marked this pull request as ready for review January 17, 2022 04:41
@tyhopp tyhopp force-pushed the fix-create-gatsby-telemetry branch from 9e1eec2 to 7faefcc Compare January 17, 2022 06:05
@tyhopp tyhopp force-pushed the fix-create-gatsby-telemetry branch from 125b6fc to ed0fc7d Compare January 17, 2022 07:37
LekoArts
LekoArts suggested changes Jan 17, 2022
View reviewed changes
integration-tests/ssr/__tests__/ssr.js Outdated Show resolved Hide resolved
packages/create-gatsby/src/__tests__/tracking.ts Outdated Show resolved Hide resolved
packages/create-gatsby/src/__tests__/tracking.ts Outdated Show resolved Hide resolved
packages/create-gatsby/src/tracking.ts Outdated Show resolved Hide resolved
@LekoArts LekoArts added type: bug An issue or pull request relating to a bug in Gatsby and removed type: bug An issue or pull request relating to a bug in Gatsby labels Jan 17, 2022
@tyhopp tyhopp force-pushed the fix-create-gatsby-telemetry branch from 9c52803 to f60dbc9 Compare January 17, 2022 08:36
@tyhopp tyhopp requested a review from LekoArts January 17, 2022 08:37
LekoArts
LekoArts approved these changes Jan 17, 2022
View reviewed changes
Copy link
Contributor

@LekoArts LekoArts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🌮

@LekoArts LekoArts merged commit 44b2ef5 into master Jan 17, 2022
@LekoArts LekoArts deleted the fix-create-gatsby-telemetry branch January 17, 2022 09:30
marvinjude pushed a commit that referenced this pull request Jan 17, 2022
@tyhopp @marvinjude
fix(create-gatsby): Respect telemetry disable (#34495)
1edb5e0 
(cherry picked from commit 44b2ef5)
@gatsbybot gatsbybot mentioned this pull request Jan 17, 2022
Merged
tyhopp added a commit that referenced this pull request Jan 17, 2022
@gatsbybot @tyhopp
fix(create-gatsby): Respect telemetry disable (#34495) (#34511)
9f9cabf 
(cherry picked from commit 44b2ef5)

Co-authored-by: Ty Hopp <tyhopp@users.noreply.github.com>
This was referenced Jan 26, 2022
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
This was referenced Feb 14, 2022
Open
Open
Merged
Merged
Merged
Open
Open
Merged
Open
@snyk-bot snyk-bot mentioned this pull request Feb 21, 2022
Open
@snyk-bot snyk-bot mentioned this pull request Apr 12, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LekoArts LekoArts LekoArts approved these changes

Assignees
No one assigned
Labels
topic: cli Related to the Gatsby CLI type: bug An issue or pull request relating to a bug in Gatsby
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Impossible to disable telemetry for the CLI
4 participants
@tyhopp @marvinjude @dhoko @LekoArts