Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(gatsby): add generic to GatsbyFunctionRequest #35029

Merged
merged 6 commits into from
Mar 14, 2022
Merged

chore(gatsby): add generic to GatsbyFunctionRequest #35029

merged 6 commits into from
Mar 14, 2022

Conversation

mckelveygreg
Copy link
Contributor

Description

Adds a generic to GatsbyFunctionRequest for the body to help more strict typescript usage easier.
The generic defaults to unknown and is also a partial of whatever is passed in to ensure that nothing explodes.

Documentation

Related Issues

Address discussion #33953

@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Mar 2, 2022
@imjoshin imjoshin changed the title add generic to GatsbyFunctionRequest chore(gatsby): add generic to GatsbyFunctionRequest Mar 3, 2022
@imjoshin imjoshin added topic: DX Developer Experience (e.g. Fast Refresh, i18n, SSR, page creation, starters) topic: TypeScript Issues and PRs related to TS in general, public typings or gatsby-plugin-typescript and removed status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer labels Mar 3, 2022
LekoArts
LekoArts suggested changes Mar 9, 2022
View reviewed changes
Copy link
Contributor

@LekoArts LekoArts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you also document this on https://www.gatsbyjs.com/docs/reference/functions/getting-started/#typescript ? Thanks!

packages/gatsby/index.d.ts Outdated Show resolved Hide resolved
LekoArts
LekoArts approved these changes Mar 14, 2022
View reviewed changes
Copy link
Contributor

@LekoArts LekoArts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@LekoArts LekoArts merged commit bf8392c into gatsbyjs:master Mar 14, 2022
@LekoArts LekoArts mentioned this pull request Mar 15, 2022
Merged
@saurabharch saurabharch mentioned this pull request Nov 30, 2023
Open
@monizb monizb mentioned this pull request Nov 30, 2023
Open
@saurabharch saurabharch mentioned this pull request Nov 30, 2023
Open
This was referenced Nov 30, 2023
Open
Open
@joeawillis joeawillis mentioned this pull request Nov 30, 2023
Open
@monizb monizb mentioned this pull request Nov 30, 2023
Open
@Rutam21 Rutam21 mentioned this pull request Nov 30, 2023
Open
@nidhi42 nidhi42 mentioned this pull request Nov 30, 2023
Open
@tonyg101 tonyg101 mentioned this pull request Nov 30, 2023
Open
This was referenced Nov 30, 2023
Open
Open
@saurabharch saurabharch mentioned this pull request Dec 1, 2023
Open
This was referenced Dec 1, 2023
Open
Open
This was referenced Dec 1, 2023
Open
Open
@kaocher82 kaocher82 mentioned this pull request Dec 1, 2023
Open
@monizb monizb mentioned this pull request Dec 1, 2023
Open
@wizbit wizbit mentioned this pull request Dec 2, 2023
Open
@MaxMood96 MaxMood96 mentioned this pull request Dec 2, 2023
Open
@ajesse11x ajesse11x mentioned this pull request Dec 2, 2023
Open
This was referenced Dec 2, 2023
Open
Open
This was referenced Dec 2, 2023
Open
Open
Open
This was referenced May 13, 2024
Open
Open
Open
Open
Open
Open
This was referenced May 14, 2024
Open
Open
Open
@monizb monizb mentioned this pull request May 14, 2024
Open
This was referenced May 14, 2024
Open
Open
@nidhi42 nidhi42 mentioned this pull request May 14, 2024
Open
This was referenced May 15, 2024
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LekoArts LekoArts LekoArts approved these changes

Assignees
No one assigned
Labels
topic: DX Developer Experience (e.g. Fast Refresh, i18n, SSR, page creation, starters) topic: TypeScript Issues and PRs related to TS in general, public typings or gatsby-plugin-typescript
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mckelveygreg @LekoArts @imjoshin