Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(gatsby): remove apis from ts,tsx #35183

Merged
merged 5 commits into from
Mar 21, 2022
Merged

fix(gatsby): remove apis from ts,tsx #35183

merged 5 commits into from
Mar 21, 2022

Conversation

wardpeet
Copy link
Contributor

@wardpeet wardpeet commented Mar 21, 2022

Description

Not all instances of getServerData or config are removed, the rule only applies to js, mjs & jsx files. Not it also supports ts, TSX.

@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Mar 21, 2022
@wardpeet wardpeet removed the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Mar 21, 2022
Copy link
Contributor

@imjoshin imjoshin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test method is clean, I like it 💪

@wardpeet
Copy link
Contributor Author

I just copied it from an already existing one 😂

@wardpeet wardpeet merged commit 8de18e7 into master Mar 21, 2022
@wardpeet wardpeet deleted the fix/modified-exports-ts branch March 21, 2022 14:53
pieh pushed a commit that referenced this pull request Mar 22, 2022
pieh pushed a commit that referenced this pull request Mar 22, 2022
(cherry picked from commit 8de18e7)

Co-authored-by: Ward Peeters <ward@coding-tech.com>
@pieh
Copy link
Contributor

pieh commented Mar 22, 2022

Published in gatsby@4.10.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants