Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(gatsby-source-wordpress): Force removal of types #37424

Merged
merged 1 commit into from
Jan 9, 2023

Conversation

tyhopp
Copy link
Contributor

@tyhopp tyhopp commented Jan 9, 2023

Description

A recent integration test failure happens because we check for no such file or directory, stat when the error message is no such file or directory, lstat.

Instead use the force option of rmSync, which ignores exceptions if the path doesn't exist.

If this doesn't fix it then I'll change this to compare no such file or directory since we don't care about stat vs lstat anyway here.

Documentation

N/A

Related Issues

N/A

@tyhopp tyhopp added the topic: source-wordpress Related to Gatsby's integration with WordPress label Jan 9, 2023
@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Jan 9, 2023
@tyhopp tyhopp removed the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Jan 9, 2023
@LekoArts LekoArts merged commit 447a558 into master Jan 9, 2023
@LekoArts LekoArts deleted the fix/wordpress-types-removal branch January 9, 2023 07:12
pieh added a commit that referenced this pull request Mar 30, 2023
…on (#37749) (#37778)

* fix(gatsby-source-wordpress): prevent inconsistent schema customization (#37749)

* panic or warn when schema customization is inconsistent

* ensure types are always properly excluded

* add blocklist of typename parts which cause a type to be excluded if it's name includes a part

(cherry picked from commit 9f26b67)

* ignore browserlist update prompt

* fix ignore

* fix(gatsby-source-wordpress): Force removal of types (#37424)

---------

Co-authored-by: Tyler Barnes <tylerdbarnes@gmail.com>
Co-authored-by: Michal Piechowiak <misiek.piechowiak@gmail.com>
Co-authored-by: Ty Hopp <tyhopp@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: source-wordpress Related to Gatsby's integration with WordPress
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants