Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make static builds deterministic by constant reactid's #95

Merged
merged 1 commit into from
Dec 1, 2015
Merged

Make static builds deterministic by constant reactid's #95

merged 1 commit into from
Dec 1, 2015

Conversation

syrusakbary
Copy link
Contributor

Make static builds deterministic by constant reactid's. Fixed #22

KyleAMathews added a commit that referenced this pull request Dec 1, 2015
Make static builds deterministic by constant reactid's
@KyleAMathews KyleAMathews merged commit 4b7ac20 into gatsbyjs:master Dec 1, 2015
@KyleAMathews
Copy link
Contributor

Thanks! Already enjoying the nice clean diffs on builds + it's fun to see the "gatsby"s littered through the generated html :-)

@KyleAMathews
Copy link
Contributor

@syrusakbary so... this isn't working after converting code to Babel as when compiled, the createReactRootIndex override gets moved below the various imports meaning the root index is already set by the time we override the function.

I'm pretty new to Babel—any suggestions on how to fix this so our override gets set in time?

EDIT:
stackoverflow: imports are hoisted

@jlengstorf
Copy link
Contributor

Hiya @syrusakbary! 👋

This is definitely late, but on behalf of the entire Gatsby community, I wanted to say thank you for being here.

Gatsby is built by awesome people like you. Let us say “thanks” in two ways:

  1. We’d like to send you some Gatsby swag. As a token of our appreciation, you can go to the Gatsby Swag Store and log in with your GitHub account to get a coupon code good for one free piece of swag. (We’ve got t-shirts and hats, plus some socks that are really razzing our berries right now.)
  2. If you’re not already part of it, we just invited you to join the Gatsby organization on GitHub. This will add you to our team of maintainers. You’ll receive an email shortly asking you to confirm. By joining the team, you’ll be able to label issues, review pull requests, and merge approved pull requests.

If you have questions, please don’t hesitate to reach out to us: tweet at @gatsbyjs and we’ll come a-runnin’.

Thanks again! 💪💜

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants