Manu WIP #11
Open
Manu WIP #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
+35
to
+47
| if (type.equals("raw")) { | ||
| // raw: 12.5% of the item cost | ||
| this.tax = (double) (0.125) * price; | ||
| } else if (type.equals("manufactured")) { | ||
| // manufactured: 12.5% of the item cost + 2% of (item cost + 12.5% of the item | ||
| // cost) | ||
| this.tax = (double) ((0.125) * price) + (0.2 * (price + (0.125 * price))); | ||
| } else if (type.equals("imported")) { | ||
| import_tax = (double) (0.1) * price; | ||
| tot_price = price + import_tax; | ||
| double super_charge = (tot_price <= 100) ? 5 : (tot_price <= 200) ? 10 : 0.5 * (tot_price); | ||
| this.tax = import_tax + super_charge; | ||
| } |
There was a problem hiding this comment.
Consider leveraging java's inheritance property to make the code cleaner and scalable.
| class TestAssignment1 { | ||
|
|
||
| @Test | ||
| void test_for_type_row() { |
There was a problem hiding this comment.
Must write test for edge cases also.
| @Order(1) | ||
| @DisplayName("Validating String and Empty field") | ||
| void test_String_and_Empty_Field() { | ||
| Input input = new Input(); |
There was a problem hiding this comment.
Expect more test cases.
| import java.util.Map; | ||
| import java.util.Scanner; | ||
|
|
||
| public class DependencyGraph { |
There was a problem hiding this comment.
We can improve on code structure.
Comment on lines
+33
to
+45
| if (type.equals("raw")) { | ||
| // raw: 12.5% of the item cost | ||
| this.tax = (double) (0.125) * price; | ||
| } else if (type.equals("manufactured")) { | ||
| // manufactured: 12.5% of the item cost + 2% of (item cost + 12.5% of the item | ||
| // cost) | ||
| this.tax = (double) ((0.125) * price) + (0.2 * (price + (0.125 * price))); | ||
| } else if (type.equals("imported")) { | ||
| import_tax = (double) (0.1) * price; | ||
| tot_price = price + import_tax; | ||
| double super_charge = (tot_price <= 100) ? 5 : (tot_price <= 200) ? 10 : 0.5 * (tot_price); | ||
| this.tax = import_tax + super_charge; | ||
| } |
There was a problem hiding this comment.
Consider using java inheritance property
completed Assignment 1,2,3,4