nuclei Assignments #12
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abhinav-adtechs
requested changes
Nov 23, 2019
| @@ -0,0 +1,14 @@ | |||
| eclipse.preferences.version=1 | |||
There was a problem hiding this comment.
Please don't commit IDE configs, generated code and binary files in git.
Comment on lines
+21
to
+25
| for(int j=0;j<3;j++) { | ||
| if (sc.hasNextInt()) { quantity=sc.nextInt();} | ||
| else if (sc.hasNextDouble()) { price=sc.nextDouble();} | ||
| else if (sc.hasNext()) { type=sc.next();} | ||
| } |
There was a problem hiding this comment.
Consider using Streams API. And try to remove if else inside the for-loop.
Comment on lines
+29
to
+44
| if (type.equalsIgnoreCase("raw")){ | ||
| tax=calRawTax(price); | ||
| cost=(price+tax)*quantity; | ||
| } | ||
| else if (type.equalsIgnoreCase("manufactured")){ | ||
| tax=calManufacturedTax(price); | ||
| cost=(price+tax)*quantity; | ||
| } | ||
| else if (type.equalsIgnoreCase("imported")){ | ||
| tax=calImportedTax(price); | ||
| cost=(price+tax)*quantity; | ||
| } | ||
| else { | ||
| System.out.println("Invalid item type."); | ||
| continue; | ||
| } |
There was a problem hiding this comment.
Consider leveraging java's inheritance property to make the code cleaner and scalable.
abhinav-adtechs
added
review done
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.