Pull Request #19
Open
Pull Request #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thejasn
requested changes
Dec 17, 2019
Assignment2/src/Main.java
Outdated
| public static void main(String[] args) | ||
| { | ||
| //String studentRecFileName = fileReadWriteUtil.getFile(); // extract and read student file from memory | ||
| //List<Student> studentRecordList = fileReadWriteUtil.readFile("studentData.txt"); |
Assignment2/src/Main.java
Outdated
| //String studentRecFileName = fileReadWriteUtil.getFile(); // extract and read student file from memory | ||
| //List<Student> studentRecordList = fileReadWriteUtil.readFile("studentData.txt"); | ||
|
|
||
| int choice = utility.getInputItemChoice(); // menu for selecting options |
There was a problem hiding this comment.
Naming convention for static classes needs to be followed.
Assignment2/src/Main.java
Outdated
| //List<Student> studentRecordList = fileReadWriteUtil.readFile("studentData.txt"); | ||
|
|
||
| int choice = utility.getInputItemChoice(); // menu for selecting options | ||
| utility.performAction(choice); // perform task according to the option chosen |
There was a problem hiding this comment.
If utility is a static class, should it be tightly coupled with the behavior of Student.
Assignment2/src/model/Course.java
Outdated
|
|
||
| public class Course implements Serializable{ | ||
| // private static final long serialVersionUID =1L; | ||
| ArrayList<String> courses; |
There was a problem hiding this comment.
Are access modifiers required ?
| return rollNumber; | ||
| } | ||
|
|
||
| public void setRollNumber(int rollNumber) { |
There was a problem hiding this comment.
Access modifiers are missing .... PMD should have broken here.
| if (studentList.isEmpty()) { | ||
| System.out.println("No user details present\n"); | ||
| } | ||
| studentList=sortByChoice(studentList, choice); |
Comment on lines
88
to
91
| if (studentList.isEmpty()) { | ||
| System.out.println("No user details present\n"); | ||
| } | ||
| studentList=sortByChoice(studentList, choice); |
There was a problem hiding this comment.
If true, should it still proceed ???
| System.out.println("User Details : \n"); | ||
| System.out.printf("%s %s %s %s %s %n \n", "Name", "Age", "Address", "Roll Number", "Courses"); | ||
|
|
||
| for (Student value : studentList) { |
There was a problem hiding this comment.
Look into java streams for iterating.
| <exclude-output /> | ||
| <content url="file://$MODULE_DIR$"> | ||
| <sourceFolder url="file://$MODULE_DIR$/src" isTestSource="false" /> | ||
| </content> |
There was a problem hiding this comment.
look into .gitignore for making sure unwanted files aren't committed.
Assignment2/src/util/utility.java
Outdated
| System.out.print("Do you want to CONTINUE? Enter (y/n): "); | ||
| String choice = sc.next(); | ||
| int inputChoice = 0; | ||
| if ("Y".equals(choice) || "y".equals(choice)) { |
There was a problem hiding this comment.
Prefer to use constants for such hard coded string.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.