added assignment 1, 2, 3, 4, 5 (WIP) #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
khushbu014
changed the title
gaurav4ever
requested changes
Nov 23, 2019
| package asgn.model; | ||
|
|
||
| //Class to describe the properties of item | ||
| public class Item { |
There was a problem hiding this comment.
Try lombok plugin.
Lombok removes the extra boiling plate code like getter and setters, Constructors etc.
| public static ArrayList<Item> getInputItem() { | ||
| Scanner sc = new Scanner(System.in); | ||
|
|
||
| System.out.println("Enter the following product details:"); |
There was a problem hiding this comment.
In question it was stated to use command line inputs. Not the scanner.
There was a problem hiding this comment.
I can take command line input for first input.
But for multiple inputs I will have to use scanner?
|
|
||
| private static void performAction(int choice) { | ||
| switch (choice) { | ||
| case 1: |
|
|
||
| import asgn.model.Node; | ||
|
|
||
| public class GraphOperation { |
There was a problem hiding this comment.
Every operation is in same class. Try to segregate the common logic
gaurav4ever
added
review done
|
khushbu014
changed the title
added 2 commits
December 10, 2019 22:36
khushbu014
changed the title
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Khushbu Goyal (SGSITS Indore) : Added Assignment no. 1 and Assignment no. 2