Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rework of extcopy, storing the offsets alongside the code #57

Draft
wants to merge 2 commits into
base: verkle-trie-proof-in-block-rebased
Choose a base branch
from
Draft

rework of extcopy, storing the offsets alongside the code #57

wants to merge 2 commits into from

Conversation

gballet
Copy link
Owner

@gballet gballet commented Jan 14, 2022 •
edited
Loading

TODO: rework the EXTCOPY code itself, using the offset data

@gballet gballet requested a review from holiman as a code owner January 14, 2022 10:36
@gballet gballet requested review from jwasinger and removed request for holiman January 14, 2022 10:36
@gballet gballet force-pushed the verkle/code-chunking/store-offsets branch from e096cd1 to 62e743d Compare January 14, 2022 10:39
@gballet gballet marked this pull request as draft January 14, 2022 12:58
@gballet gballet force-pushed the verkle-trie-proof-in-block-rebased branch 2 times, most recently from e1adb6f to dd6425e Compare March 25, 2022 10:29
@gballet gballet mentioned this pull request May 3, 2022
Merged
@gballet
Copy link
Owner Author

gballet commented May 3, 2022 •
edited
Loading

note to self: this PR has to be merged before production, as not having it represents a potential DoS vector because the code will be re-chunkified each time a code-related instruction is called.

@gballet
Copy link
Owner Author

gballet commented Aug 29, 2024

Revisiting this issue 2 years later, some comments:

  • It is indeed a potential DOS vector if the code size limit is increased, as one could inexpensively call EXTCODECOPY multiple times.
  • This being said, EOF/EOFv0 solve this problem, in which case this PR would no longer be necessary.

I'm putting it on hold until we made some progress on EOFv0.

@gballet gballet mentioned this pull request Aug 29, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jwasinger jwasinger Awaiting requested review from jwasinger

@holiman holiman Awaiting requested review from holiman holiman will be requested when the pull request is marked ready for review holiman is a code owner

Assignees
No one assigned
Labels
on-hold
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@gballet