Bug with display popups turned off and direct-to-REPL evaluation.

gcv · Aug 28, 2022 · ef72f07 · ef72f07
1 parent d411c02
commit ef72f07
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 6 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -11,6 +11,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 ### Fixed
 
 - A problem where certain Julia forms were not correctly evaluated as top-level.
+- Bug with direct-to-REPL evaluation with `julia-snail-repl-display-eval-results` turned off.
 
 
 ### Added

diff --git a/julia-snail.el b/julia-snail.el
@@ -501,12 +501,13 @@ Returns nil if the poll timed out, t otherwise."
                       :async nil))
                (popup-params (julia-snail--popup-params block-end))
                (str (if (equal err :nothing)
-                        (julia-snail--send-to-server
-                          :Main
-                          (format "JuliaSnail.PopupDisplay.format(ans, %s, %s)"
-                                  (car popup-params)
-                                  (cadr popup-params))
-                          :async nil)
+                        (when julia-snail-popup-display-eval-results
+                          (julia-snail--send-to-server
+                            :Main
+                            (format "JuliaSnail.PopupDisplay.format(ans, %s, %s)"
+                                    (car popup-params)
+                                    (cadr popup-params))
+                            :async nil))
                       "error")))
           (julia-snail--popup-display popup-block-end str :use-cleanup-kludge (eq :command julia-snail-popup-display-eval-results)))
       ;; evaluate through the Snail server: