Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update #194

Merged
merged 6 commits into from
Feb 16, 2023
Merged

update #194

merged 6 commits into from
Feb 16, 2023

Conversation

joamatab
Copy link
Contributor

@joamatab joamatab commented Feb 16, 2023

  • update floorplan size
  • fix optical labels, make sure optical and electrical labels match
  • fix pads spacing to 125um
  • flip orientation of heated rings

Thank you Lukas and Simon!

image

@simbilod
@mustafacc
@lukasc-ubc
@SkandanC

@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented Feb 16, 2023

Sourcery Code Quality Report

❌  Merging this PR will decrease code quality in the affected files by 0.21%.

Quality metrics Before After Change
Complexity 1.93 ⭐ 1.93 ⭐ 0.00
Method Length 84.09 🙂 83.47 🙂 -0.62 👍
Working memory 10.39 😞 10.45 😞 0.06 👎
Quality 66.25% 🙂 66.04% 🙂 -0.21% 👎
Other metrics Before After Change
Lines 2035 2049 14
Changed files Quality Before Quality After Quality Change
ubcpdk/components.py 81.06% ⭐ 80.98% ⭐ -0.08% 👎
ubcpdk/tech.py 64.62% 🙂 64.50% 🙂 -0.12% 👎
ubcpdk/samples/test_masks.py 96.12% ⭐ 95.25% ⭐ -0.87% 👎
ubcpdk/samples/ubc_joaquin_matres1.py 77.40% ⭐ 77.23% ⭐ -0.17% 👎
ubcpdk/samples/ubc_simon.py 46.43% 😞 45.25% 😞 -1.18% 👎
ubcpdk/samples/write_mask.py 82.69% ⭐ 82.69% ⭐ 0.00%

Here are some functions in these files that still need a tune-up:

File Function Complexity Length Working Memory Quality Recommendation
ubcpdk/samples/ubc_simon.py crosstalk_experiment_parametrized_mask 11 🙂 990 ⛔ 24 ⛔ 24.96% ⛔ Try splitting into smaller methods. Extract out complex expressions
ubcpdk/samples/ubc_simon.py ring_single_heater 0 ⭐ 385 ⛔ 25 ⛔ 36.78% 😞 Try splitting into smaller methods. Extract out complex expressions
ubcpdk/samples/ubc_simon.py resonator_proximity_io 6 ⭐ 322 ⛔ 16 ⛔ 37.62% 😞 Try splitting into smaller methods. Extract out complex expressions
ubcpdk/tech.py get_layer_stack 0 ⭐ 217 ⛔ 13 😞 52.00% 🙂 Try splitting into smaller methods. Extract out complex expressions
ubcpdk/components.py add_fiber_array 0 ⭐ 120 😞 24 ⛔ 52.22% 🙂 Try splitting into smaller methods. Extract out complex expressions

Legend and Explanation

The emojis denote the absolute quality of the code:

  • ⭐ excellent
  • 🙂 good
  • 😞 poor
  • ⛔ very poor

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.


Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Help us improve this quality report!

@codecov
Copy link

codecov bot commented Feb 16, 2023

Codecov Report

Merging #194 (7ee3359) into main (24da56f) will decrease coverage by 6.07%.
The diff coverage is 4.54%.

❗ Current head 7ee3359 differs from pull request most recent head 74c1a39. Consider uploading reports for the commit 74c1a39 to get more accurate results

@@            Coverage Diff             @@
##             main     #194      +/-   ##
==========================================
- Coverage   53.85%   47.79%   -6.07%     
==========================================
  Files          23       23              
  Lines         999     1132     +133     
==========================================
+ Hits          538      541       +3     
- Misses        461      591     +130     
Impacted Files Coverage Δ
ubcpdk/samples/test_masks.py 0.00% <ø> (ø)
ubcpdk/samples/ubc_joaquin_matres1.py 0.00% <0.00%> (ø)
ubcpdk/samples/ubc_simon.py 0.00% <0.00%> (ø)
ubcpdk/samples/write_mask.py 0.00% <0.00%> (ø)
ubcpdk/tech.py 93.20% <ø> (ø)
ubcpdk/components.py 97.67% <77.77%> (+0.02%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@joamatab joamatab merged commit ffe42be into main Feb 16, 2023
@joamatab joamatab deleted the merge_simon branch February 16, 2023 20:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant