Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(gstd) use stabilized panic_info_message feature from rust 1.81 #4098

Merged
merged 7 commits into from
Sep 9, 2024

Conversation

StackOverflowExcept1on
Copy link
Member

@StackOverflowExcept1on StackOverflowExcept1on commented Jul 29, 2024

Resolves #1857
The panic location will now be removed by the stable compiler. Merge of this PR is scheduled for September 5th.

@StackOverflowExcept1on StackOverflowExcept1on added A0-pleasereview PR is ready to be reviewed by the team A5-dontmerge PR should not be merged yet D3-gstd Gear Standard Library labels Jul 29, 2024
Base automatically changed from av/update-rust to master August 2, 2024 10:52
@StackOverflowExcept1on
Copy link
Member Author

For some reason new version of rust compiler does not strip /home/username 🫤

@StackOverflowExcept1on
Copy link
Member Author

I figured out why panic locations are not removed and it is probably a regression. We can merge this without waiting for rust-lang/rust#129491.

@StackOverflowExcept1on StackOverflowExcept1on removed the A5-dontmerge PR should not be merged yet label Sep 5, 2024
@breathx breathx merged commit bc70fa0 into master Sep 9, 2024
10 checks passed
@breathx breathx deleted the av/panic-handler-1.81 branch September 9, 2024 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A0-pleasereview PR is ready to be reviewed by the team D3-gstd Gear Standard Library
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve diagnostic when gstd without 'debug'
2 participants