Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(client): fallback 'gefyra run' namespace from kubeconfig #140

Merged
merged 3 commits into from
Aug 11, 2022
Merged

feat(client): fallback 'gefyra run' namespace from kubeconfig #140

merged 3 commits into from
Aug 11, 2022

Conversation

Schille
Copy link
Collaborator

@Schille Schille commented Aug 9, 2022

closes #125

@SteinRobert
Copy link
Contributor

LGTM - could you please add a test for this one? :)

@sonarcloud
Copy link

sonarcloud bot commented Aug 10, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@Schille
Copy link
Collaborator Author

Schille commented Aug 10, 2022

I added two test cases in the github workflow.

@SteinRobert
Copy link
Contributor

LGTM, thank you!

@SteinRobert SteinRobert merged commit f83e90f into main Aug 11, 2022
@SteinRobert SteinRobert deleted the feat/#125 branch April 26, 2024 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SteinRobert SteinRobert Awaiting requested review from SteinRobert

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fallback to namespace in kube config
2 participants
@Schille @SteinRobert