Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PodSecurity admission label to configure namespace as privileged #258

Merged
merged 1 commit into from
Nov 9, 2022

Conversation

LittleFox94
Copy link
Contributor

This is required to run stowaway on PodSecurity Admission-enabled clusters and since it is only a label, it won't do any harm on other clusters.

Signed-off-by: Mara Sophie Grosch littlefox@lf-net.org

@Schille
Copy link
Collaborator

Schille commented Nov 9, 2022

Welcome to Gefyra @LittleFox94
This is awesome. Thank you very much for this contribution.

@LittleFox94
Copy link
Contributor Author

@Schille :)

I'll probably look into the CI errors later today

This is required to run stowaway on PodSecurity Admission-enabled
clusters and since it is only a label, it won't do any harm on other
clusters.

Signed-off-by: Mara Sophie Grosch <littlefox@lf-net.org>
@sonarcloud
Copy link

sonarcloud bot commented Nov 9, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link
Contributor

@SteinRobert SteinRobert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@SteinRobert SteinRobert merged commit a3a145d into gefyrahq:main Nov 9, 2022
@LittleFox94 LittleFox94 deleted the pod-security-admission branch November 9, 2022 23:41
@LittleFox94
Copy link
Contributor Author

oh no, my PR stands out in release notes with not having a feat prefix :D

@SteinRobert
Copy link
Contributor

:D
We currently do not enforce semantic commit messages, but use them for all our projects. No worries :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants