chore: add --pull and --platform to run

client/gefyra/api/run.py

@@ -43,6 +43,8 @@ def run(
     namespace: str = "",
     env: Optional[List] = None,
     env_from: str = "",
+    pull: str = "missing",
+    platform: str = "linux/amd64",
 ) -> bool:
     from kubernetes.client import ApiException
     from docker.errors import APIError
@@ -116,6 +118,8 @@ def run(
             dns_search=dns_search,
             auto_remove=auto_remove,
             volumes=volumes,
+            pull=pull,
+            platform=platform,
         )
     except APIError as e:
         if e.status_code == 409:

client/gefyra/cli/run.py

@@ -80,6 +80,20 @@
 @click.option(
     "-i", "--image", help="The docker image to run in Gefyra", type=str, required=True
 )
+@click.option(
+    "--pull",
+    type=click.Choice(["always", "missing"], case_sensitive=False),
+    help="Define whether image should always be pulled",
+    required=False,
+    default="missing",
+)
+@click.option(
+    "--platform",
+    type=str,
+    help="Define platform for image pull. Default: linux/amd64",
+    required=False,
+    default="linux/amd64",
+)
 @click.option(
     "--connection-name", type=str, callback=check_connection_name, required=False
 )
@@ -94,6 +108,8 @@ def run(
     command,
     name,
     image,
+    pull,
+    platform,
     connection_name,
 ):
     from gefyra import api
@@ -111,5 +127,7 @@ def run(
         auto_remove=auto_remove,
         volumes=volume,
         detach=detach,
+        pull=pull,
+        platform=platform,
         connection_name=connection_name,
     )

client/gefyra/local/bridge.py

@@ -4,6 +4,7 @@
 
 from docker.models.containers import Container
 
+from gefyra.cli import console
 from gefyra.configuration import ClientConfiguration
 from gefyra.local.cargo import get_cargo_ip_from_netaddress
 from gefyra.types import GefyraLocalContainer
@@ -140,9 +141,20 @@ def deploy_app_container(
     env: Optional[Dict] = None,
     auto_remove: bool = False,
     dns_search: Optional[List[str]] = None,
+    pull: Optional[str] = "missing",
+    platform: Optional[str] = "linux/amd64",
 ) -> Container:
     import docker
 
+    if pull == "always":
+        console.info(f"Pulling image {image}...")
+        if ":" in image:
+            repo, tag = image.split(":")
+        else:
+            repo, tag = image, "latest"
+        config.DOCKER.images.pull(repository=repo, tag=tag, platform=platform)
+        console.info(f"Pulling image {image} done.")
+
     if not dns_search:
         dns_search = ["default"]
 

client/tests/e2e/base.py

@@ -669,7 +669,6 @@ def test_h_run_gefyra_unbridge_with_name(self):
             ["unbridge", "mypyserver-to-default.deploy.hello-nginxdemo"],
             catch_exceptions=False,
         )
-        print(res.output)
         self.assertEqual(res.exit_code, 0)
         pod_container_dict = get_pods_and_containers_for_workload(
             default_configuration, "hello-nginxdemo", "default", "deployment"
@@ -980,7 +979,6 @@ def test_r_reconnect(self):
             ["connections", "connect", "-n", CONNECTION_NAME],
             catch_exceptions=False,
         )
-        print(res.output)
         self.assertEqual(res.exit_code, 0)
         self.assert_cargo_running()
 
@@ -1029,6 +1027,42 @@ def test_s_run_via_cli(self):
         self.assert_namespace_not_found("gefyra")
         self.assert_cargo_not_running()
 
+    def test_s_run_via_cli_with_pull(self):
+        res = self.gefyra_up()
+        self.assertTrue(res)
+        self.assert_cargo_running()
+        self.assert_gefyra_connected()
+        runner = CliRunner()
+        res = runner.invoke(
+            cli,
+            [
+                "run",
+                "--image",
+                "quay.io/gefyra/pyserver",
+                "--name",
+                "mypyserver",
+                "--namespace",
+                "default",
+                "--expose",
+                "8000:8000",
+                "--detach",
+                "--rm",
+                "--command",
+                "python3 local.py",
+                "--connection-name",
+                CONNECTION_NAME,
+                "--pull",
+                "always",
+            ],
+            catch_exceptions=False,
+        )
+        self.assertEqual(res.exit_code, 0)
+        self.assertIn("Pulling image", res.output)
+        self.assert_http_service_available("localhost", 8000)
+        self.gefyra_down()
+        self.assert_namespace_not_found("gefyra")
+        self.assert_cargo_not_running()
+
     def test_s_run_via_cli_without_connection_name(self):
         res = self.gefyra_up()
         self.assertTrue(res)