fowners, fperms: Fix handling of relative pathnames #1027
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
See also #364. |
ulm
added a commit
to ulm/portage
that referenced
this pull request
Apr 28, 2023
PMS section 12.3.9 specifies that fowners and fperms "[take] paths
relative to the image directory."
Currently, these helpers interpret any pathnames not beginning with a
slash as relative to the current working directory (after printing a
QA warning). This contradicts the spec.
It is also inconsistent with other helpers like insinto or dostrip,
which expand their pathnames relative to ${ED}.
Bug: https://bugs.gentoo.org/905223
Closes: gentoo#1027
Signed-off-by: Ulrich Müller <[email protected]>
ulm
added a commit
to ulm/portage
that referenced
this pull request
Apr 29, 2023
PMS section 12.3.9 specifies that fowners and fperms "[take] paths
relative to the image directory."
Currently, these helpers interpret any pathnames not beginning with a
slash as relative to the current working directory (after printing a
QA warning). This contradicts the spec.
It is also inconsistent with other helpers like insinto or dostrip,
which expand their pathnames relative to ${ED}.
Bug: https://bugs.gentoo.org/905223
Closes: gentoo#1027
Signed-off-by: Ulrich Müller <[email protected]>
|
I don't mind changing the behavior but I'd prefer if you left The QA warning in (and we wouldn't rely on either behavior, at least for some time). |
Re-added QA warnings, with slightly different wording. Is is o.k. to remove them by the end of 2024? |
PMS section 12.3.9 specifies that fowners and fperms "[take] paths
relative to the image directory."
Currently, these helpers interpret any pathnames not beginning with a
slash as relative to the current working directory (after printing a
QA warning). This contradicts the spec.
It is also inconsistent with other helpers like insinto or dostrip,
which expand their pathnames relative to ${ED}.
Bug: https://bugs.gentoo.org/905223
Closes: gentoo#1027
Signed-off-by: Ulrich Müller <[email protected]>
Signed-off-by: Ulrich Müller <[email protected]>
|
Well, now it suggests that it's fine to use it, except it isn't because people may still be using old Portage versions that exhibit the old behavior. The QA warning should make it clear "don't use it until because old Portage doesn't handle it". |
Suggested-by: Michał Górny <[email protected]> Signed-off-by: Ulrich Müller <[email protected]>
|
Better now? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PMS section 12.3.9 specifies that fowners and fperms "[take] paths relative to the image directory."
Currently, these helpers interpret any pathnames not beginning with a slash as relative to the current working directory (after printing a QA warning). This contradicts the spec.
It is also inconsistent with other helpers like insinto or dostrip, which expand their pathnames relative to ${ED}.
Closes: https://bugs.gentoo.org/905223