emerge: allow --onlydeps merge if root package(s) masked by license #1087
Conversation
|
Hrm. For some reason when I test this in a musl docker image I don't see the same behavior I see on my development system with As such, this is NOT ready for merge. |
| if onlydeps and self._dynamic_config._needed_license_changes: | ||
| # needed license changes should only be fatal for packages that | ||
| # would actually be installed | ||
| return True, myfavorites |
There was a problem hiding this comment.
You've ignored non-license autounmask changes here. It would only make sense to return True here if there were no non-license autounmask changes. Ultimately, I think it will be much cleaner to set empty LICENSE metadata for the onlydeps package instance, rather than trigger autoumask for a LICENSE that you intend to ignore anyway.
There was a problem hiding this comment.
Setting license metadata to empty is an excellent suggestion. I'll look into it. Thanks!
This commit makes it possible to merge dependencies for packages that are masked by license since the masked package is not actually going to be installed. Signed-off-by: Tom Gillespie <[email protected]>
This commit makes it possible to merge dependencies for packages that are masked by license since the masked package is not actually going to be installed.