PB-871 : code clean-up

moving slash enforcing function back to where other base URLs are in the config

src/api/features/features.api.js

@@ -114,8 +114,6 @@ export function extractOlFeatureGeodesicCoordinates(feature) {
  * @param {Number} [offset] Offset of how many items the identification should start after. This
  *   enables us to do some "pagination" or "load more" (if you already have 10 features, set an
  *   offset of 10 to get the 10 next, 20 in total).
- * @param {String | null} [api3UrlOverride=null] The base URL to access API3 services. If none is
- *   given, the default from config.js will be used. Default is `null`
  * @returns {Promise<LayerFeature[]>}
  */
 export async function identifyOnGeomAdminLayer({

src/config/baseUrl.config.js

@@ -1,4 +1,15 @@
-import { enforceEndingSlashInUrl } from '@/config'
+/**
+ * Adds a slash at the end of the URL if there is none
+ *
+ * @param {String} url
+ * @returns {String} The URL with a trailing slash
+ */
+export function enforceEndingSlashInUrl(url) {
+    if (url && !url.endsWith('/')) {
+        return `${url}/`
+    }
+    return url
+}
 
 /**
  * All default base URLs for services.

src/modules/menu/components/debug/BaseUrlOverrideModal.vue

@@ -3,8 +3,11 @@ import { FontAwesomeIcon } from '@fortawesome/vue-fontawesome'
 import { computed, ref } from 'vue'
 import { useStore } from 'vuex'
 
-import { enforceEndingSlashInUrl } from '@/config'
-import { baseUrlOverrides, defaultBaseUrlConfig } from '@/config/baseUrl.config'
+import {
+    baseUrlOverrides,
+    defaultBaseUrlConfig,
+    enforceEndingSlashInUrl,
+} from '@/config/baseUrl.config'
 import ModalWithBackdrop from '@/utils/components/ModalWithBackdrop.vue'
 
 const dispatcher = { dispatcher: 'BaseUrlOverrideModal.vue' }

src/router/storeSync/BaseUrlOverrideParamConfig.class.js

@@ -1,9 +1,9 @@
-import { baseUrlOverrides } from '@/config/baseUrl.config'
+import { baseUrlOverrides, enforceEndingSlashInUrl } from '@/config/baseUrl.config'
 import AbstractParamConfig from '@/router/storeSync/abstractParamConfig.class'
 
 export default function createBaseUrlOverrideParamConfig({ urlParamName, baseUrlPropertyName }) {
     function dispatchBaseUrlOverride(to, store, urlParamValue) {
-        baseUrlOverrides[baseUrlPropertyName] = urlParamValue
+        baseUrlOverrides[baseUrlPropertyName] = enforceEndingSlashInUrl(urlParamValue)
         store.dispatch('setHasBaseUrlOverrides', { hasBaseUrlOverrides: !!urlParamValue })
     }