1115 proofreading changes 1 #1123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Robinlovelace
commented
Sep 24, 2024
Robinlovelace
commented
- Map making -> map-making throughout
- Real world -> real-world
- More fixes to c1
- use-case -> use case
- Finish proofing changes to c1
19 tasks
Nowosad
reviewed
Sep 25, 2024
01-introduction.Rmd
Outdated
| @@ -173,7 +173,7 @@ leaflet() |> | |||
| popup = popup) | |||
| ``` | |||
|
|
|||
| ```{r interactive, fig.cap="The blue markers indicate where the authors are from. The basemap is a tiled image of the Earth at night provided by NASA. Interact with the online version at r.geocompx.org, for example by zooming in and clicking on the popups.", out.width="100%", fig.scap="Where the authors are from.", echo=FALSE} | |||
| ```{r interactive, fig.cap="The blue markers indicate where the authors are from. The basemap is a tiled image of the earth at night provided by NASA. Interact with the online version at r.geocompx.org, for example by zooming in and clicking on the pop-ups.", out.width="100%", fig.scap="Where the authors are from.", echo=FALSE} | |||
There was a problem hiding this comment.
@Robinlovelace Earth->earth is a surprising change for me
There was a problem hiding this comment.
Me too, it's a planet! Happy to revert.
There was a problem hiding this comment.
@Robinlovelace yes, please revert. And if you could -- then merge the PR -- I plan to work on including changes to a few other chapters soon.
Nowosad
reviewed
Sep 25, 2024
Nowosad
reviewed
Sep 25, 2024
Nowosad
reviewed
Sep 25, 2024
Co-authored-by: Jakub Nowosad <Nowosad@users.noreply.github.com>
Co-authored-by: Jakub Nowosad <Nowosad@users.noreply.github.com>
github-actions bot
pushed a commit
that referenced
this pull request
Sep 25, 2024
* Map making -> map-making throughout * Real world -> real-world * More fixes to c1 * use-case -> use case * Finish proofing changes to c1 * Apply suggestions from code review * Update 09-mapping.Rmd Co-authored-by: Jakub Nowosad <Nowosad@users.noreply.github.com> * Update 09-mapping.Rmd Co-authored-by: Jakub Nowosad <Nowosad@users.noreply.github.com> * earth -> Earth * Earth --------- Co-authored-by: Jakub Nowosad <Nowosad@users.noreply.github.com> a98ecd0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.