Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

c4 review #675

Merged
merged 108 commits into from
Dec 13, 2021
Merged

c4 review #675

merged 108 commits into from
Dec 13, 2021

Conversation

Robinlovelace
Copy link
Collaborator

No description provided.

@Robinlovelace Robinlovelace changed the title Split-out pkg loading and reading for #669 c4 review Nov 11, 2021
@Robinlovelace Robinlovelace marked this pull request as ready for review December 9, 2021 23:17
sd 'bb_world' 'bb' 01-introduction.Rmd
02-spatial-data.Rmd
03-attribute-operations.Rmd
04-spatial-operations.Rmd
05-geometry-operations.Rmd
06-reproj.Rmd
07-read-write-plot.Rmd
08-mapping.Rmd
09-gis.Rmd
10-algorithms.Rmd
11-spatial-cv.Rmd
12-transport.Rmd
13-location.Rmd
14-eco.Rmd
15-synthesis.Rmd
DESCRIPTION
README.Rmd
README.md
_01-ex.Rmd
_02-ex.Rmd
_03-ex.Rmd
_04-ex.Rmd
_05-ex.Rmd
_06-ex.Rmd
_07-ex.Rmd
_404.Rmd
apps/CycleHireApp/app.R
apps/coffeeApp/app.R
code/01-cranlogs.R
code/02-contpop.R
code/02-datum-fig.R
code/02-raster-crs.R
code/02-raster-intro-plot.R
code/02-raster-intro-plot2.R
code/02-vector-crs.R
code/02-vectorplots.R
code/03-cont-raster-plot.R
code/04-areal-example.R
code/04-focal-example.R
code/04-local-operations.R
code/04-ndvi.R
code/04-raster-subset.R
code/04-spatial-join.R
code/05-bilinear.R
code/05-contour-tmap.R
code/05-extend-example.R
code/05-pointextr.R
code/05-raster-vectorization1.R
code/05-raster-vectorization2.R
code/05-us-regions.R
code/05-vector-rasterization1.R
code/05-vector-rasterization2.R
code/05-venn-clip.R
code/08-break-styles.R
code/08-layout1.R
code/08-layout2.R
code/08-layout3.R
code/08-map-pkgs.R
code/08-tmpal.R
code/08-tmshape.R
code/08-tmstyles.R
code/08-urban-animation.R
code/08-usboundaries.R
code/09-saga-wetness.R
code/09-sliver.R
code/09-tsp.R
code/10-centroid-alg.R
code/10-centroid-setup.R
code/10-hello.R
code/10-polycent.R
code/11-partitioning.R
code/11-spatial-cv-jm.R
code/11-svm.R
code/12-cycleways.R
code/12-desire.R
code/12-transport-data-gen.R
code/12-zones.R
code/13-location-jm.R
code/14-eco.R
code/14-rf.R
code/add-impact.R
code/before_script.R
code/chapters/01-introduction.R
code/chapters/02-spatial-data.R
code/chapters/03-attribute-operations.R
code/chapters/04-spatial-operations.R
code/chapters/05-geometry-operations.R
code/chapters/06-reproj.R
code/chapters/07-read-write-plot.R
code/chapters/08-mapping.R
code/chapters/09-gis.R
code/chapters/10-algorithms.R
code/chapters/11-spatial-cv.R
code/chapters/12-transport.R
code/chapters/13-location.R
code/chapters/14-eco.R
code/chapters/15-synthesis.R
code/chapters/README.R
code/chapters/index.R
code/chapters/references.R
code/de_9im.R
code/extra-pkgs.R
code/frontcover.R
code/generate-chapter-code.R
code/hex_sticker.R
code/list-contributors.R
code/old-to-future-remove/04_spatial_incongruence.R
code/old-to-future-remove/06_raster_reprojection_tests.R
code/old-to-future-remove/08-uscolonize.R
code/old-to-future-remove/10-centroid.R
code/old-to-future-remove/10-earthquakes.R
code/old-to-future-remove/12-code-extension.R
code/old-to-future-remove/12-desire-front.R
code/old-to-future-remove/globe.R
code/old-to-future-remove/sfr-class-diagram-gen.R
code/old-to-future-remove/spData.R
code/sf-classes.R
code/sf-revdep.R
extdata/postgis_data.Rdata
geocompr.Rproj
index.Rmd
references.Rmd
@Nowosad
Copy link
Member

Nowosad commented Dec 10, 2021

@Robinlovelace ready for review?

@Robinlovelace
Copy link
Collaborator Author

Ready for review, finally! Thanks for the nudges @Nowosad !

@Robinlovelace
Copy link
Collaborator Author

Nudge on this...

@Nowosad
Copy link
Member

Nowosad commented Dec 13, 2021

Hi @Robinlovelace - I remember about this. I plan do my review on Thursday.

02-spatial-data.Rmd Outdated Show resolved Hide resolved
04-spatial-operations.Rmd Outdated Show resolved Hide resolved
04-spatial-operations.Rmd Outdated Show resolved Hide resolved
04-spatial-operations.Rmd Outdated Show resolved Hide resolved
04-spatial-operations.Rmd Outdated Show resolved Hide resolved
04-spatial-operations.Rmd Outdated Show resolved Hide resolved
04-spatial-operations.Rmd Outdated Show resolved Hide resolved
04-spatial-operations.Rmd Outdated Show resolved Hide resolved
geocompr.bib Show resolved Hide resolved
@Robinlovelace
Copy link
Collaborator Author

@Robinlovelace this .bib removes some of the new references...

That's not a problem, we can sort out bibliographies post merge.

@Nowosad
Copy link
Member

Nowosad commented Dec 13, 2021

@Robinlovelace feel free to merge it (but please do not forget about fixing bib later).

@Robinlovelace Robinlovelace merged commit 57e06af into main Dec 13, 2021
@Robinlovelace Robinlovelace deleted the c4-v2-updates-rl branch December 13, 2021 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants