Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC: Add contributors section to changelog #131

Merged
merged 3 commits into from
Jun 13, 2022
Merged

Conversation

brendan-ward
Copy link
Member

This follows the model of pandas / numpy of including a contributors section to each release in the changelog, now that we have more contributors. I only added this for 0.4.0.

@brendan-ward brendan-ward added this to the Version 0.4.0 milestone Jun 9, 2022
@brendan-ward
Copy link
Member Author

Reminder to self: needs update for #130 once merged

CHANGES.md Show resolved Hide resolved
@@ -51,6 +51,15 @@
- fix passing gdal creation parameters in `write_dataframe` (#62)
- fix passing kwargs to GDAL in `write_dataframe` (#67)

### Contributors

People with a “+” by their names contributed a patch for the first time.
Copy link
Contributor

@weiji14 weiji14 Jun 10, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI, this is actually meant to be generated using https://github.com/pandas-dev/pandas/blob/v1.4.2/doc/sphinxext/contributors.py. There will be a way to use a sphinx directive like .. contributors:: v0.3.0..v0.4.0.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@brendan-ward I do this for geopandas as well (although I only seem to include it in the github release notes, and not in the changelog file (I assume for length purposes, but that's not (yet) an issue here): https://github.com/geopandas/geopandas/releases/tag/v0.10.0
I have a script locally to create that (based on the pandas one), will share that.

@brendan-ward brendan-ward merged commit 9a5c1af into main Jun 13, 2022
@brendan-ward brendan-ward deleted the contributors_0_4_0 branch June 13, 2022 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants