FIX: Avoid duplicate count of features #151
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| if max_features > feature_count: | ||
| max_features = feature_count | ||
| elif max_features > feature_count: | ||
| max_features = feature_count | ||
|
|
||
| return skip_features, max_features |
There was a problem hiding this comment.
One small comment: should we maybe rename this processed max_features (not the original keyword) to num_features, to make the actual meaning clearer?
There was a problem hiding this comment.
Yes, good idea. Coming up... (sorry, should have requested review on this)
There was a problem hiding this comment.
sorry, should have requested review on this
no, it has been here for a long time, no problem to merge (it's easy to do follow-ups if needed)
This was referenced Sep 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As noted in #149 comment, we were calculating the count of features twice, which incurs extra and unnecessary overhead. This removes that duplication.