ENH: expose Arrow-based IO as read_arrow + doc #191
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
brendan-ward
approved these changes
Jan 4, 2023
There was a problem hiding this comment.
Thanks @jorisvandenbossche - this looks good with a couple very minor suggestions.
Tested the new functionality locally thanks to support for Arrow in latest homebrew GDAL and am seeing some nice speedups.
Co-authored-by: Brendan Ward <bcward@astutespruce.com>
We might want to enable it in the future by default? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up on #155 to address the comment at #155 (review) to add a raw IO function for pyarrow.Table (so without already the direct conversion to (geo)pandas).
This PR adds a
read_arrowfunction (and removing it as option from the numpy-based rawreadfunction).