FIX: Only use transactions when writing features if layer supports them #203
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brendan-ward
commented
Jan 14, 2023
| @@ -394,7 +410,7 @@ def test_write_supported(tmpdir, naturalearth_lowres, driver): | |||
| # we take the first record only. | |||
| meta["geometry_type"] = "MultiPolygon" | |||
|
|
|||
| filename = tmpdir / "test" | |||
| filename = tmpdir / f"test{DRIVER_EXT[driver]}" | |||
There was a problem hiding this comment.
This was added because GDAL raises errors for some drivers if the extension is not what is required; i.e., even though we don't test OpenFileGDB in this block, it must have a .gdb extension. This is an attempt to future-proof adding additional drivers to DRIVERS.
jorisvandenbossche
approved these changes
Jan 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OpenFileGDB now supports write from GDAL 3.6.0 onwards, but does not support transactions. We were always assuming transaction support was present because it was available for all drivers we specifically tested previously (though GDAL makes clear not all datasets / layers support transactions).
This adds a check for that capability and creates features without a transaction if layer doesn't support them, and adds a test to ensure that we can write OpenFileGDB correctly now.