-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ENH: add automatic detection of 2.5D in write_dataframe #223
ENH: add automatic detection of 2.5D in write_dataframe #223
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for looking into this! Couple of quick questions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for working on this @theroggy . Per the comment, I wonder if we can more deliberately catch the GDAL error for FlatGeobuf to make a nicer error message.
…etection-of-2.5D-in-write_dataframe
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @theroggy ; the failing test will be a helpful signal that GDAL fixed it. Thanks for reporting the bug there.
The geopandas test suite discovered one issue with this (https://github.com/geopandas/geopandas/actions/runs/4454470754/jobs/7823684402?pr=2834): if you have mixed 3D geometry types, the geometry_type gets inferred as "2.5D Unknown", which then gives "Geometry type is not supported: 2.5D Unknown" I suppose for the case of mixed, we just need to use "Unknown" without prepending "2.5D" |
I'll have a look... |
closes #222
apparently closes #121 as well