Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: Standardize 2.5D => Z in geometry type labels #234

Merged
merged 3 commits into from
Apr 2, 2023
Merged

Conversation

brendan-ward
Copy link
Member

Resolves #225

This standardizes from 2.5D <type> to <type> Z for geometry type labels.

Copy link
Member

@jorisvandenbossche jorisvandenbossche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Do we want to keep some test with the 2.5D version to ensure this keeps working as well? (it's difficult to see from the diff if that's the case)

@brendan-ward
Copy link
Member Author

We have a test test_geopandas_io.py::test_write_geometry_z_types that tests setting the geometry type when writing a dataset that uses both 2.5D and Z variants (didn't need to be updated here). I think that tests the only case where geometry type is an input.

@brendan-ward brendan-ward merged commit 976a705 into main Apr 2, 2023
@brendan-ward brendan-ward deleted the issue225 branch April 2, 2023 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Choose a consistent way of dealing with +2D geometries
2 participants