Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: Fix integer overflow when reading int64 column #260

Merged

Conversation

theroggy
Copy link
Member

@theroggy theroggy commented Aug 9, 2023

Closes #259

@theroggy theroggy changed the title Fix integer overflow when reading .gpkg Fix integer overflow when reading int64 column Aug 9, 2023
@theroggy theroggy changed the title Fix integer overflow when reading int64 column BUG: Fix integer overflow when reading int64 column Aug 9, 2023
Copy link
Member

@brendan-ward brendan-ward left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @theroggy !

pyogrio/_ogr.pxd Show resolved Hide resolved
pyogrio/tests/test_raw_io.py Outdated Show resolved Hide resolved
pyogrio/tests/test_raw_io.py Outdated Show resolved Hide resolved
@brendan-ward brendan-ward merged commit d70f109 into geopandas:main Aug 10, 2023
17 checks passed
@theroggy theroggy deleted the Fix-integer-overflow-when-reading-.gpkg branch August 10, 2023 16:51
@OwenLu88
Copy link

OwenLu88 commented Oct 8, 2023

I'm using the 0.6.0 version now. I don't know how to fix it in the current version. Could you help me?

@theroggy
Copy link
Member Author

theroggy commented Oct 8, 2023

It depends a bit on your specific needs, but using the current version you could try using read_datafram with use_arrow=True. This is a bit experimental, so you could run in other issues, but it is something you can try without having to wait for a new version to land.

@OwenLu88
Copy link

OwenLu88 commented Oct 9, 2023

OK. Thanks. I will try it.
BTW, do you have a plan to release a new version(0.7.0)?

@OwenLu88
Copy link

OwenLu88 commented Oct 9, 2023

Wow, it's a good solution using read_dataframe with use_arrow=True can fix the issue. Very very thanks.

@theroggy
Copy link
Member Author

theroggy commented Oct 9, 2023

OK. Thanks. I will try it. BTW, do you have a plan to release a new version(0.7.0)?

Yes, but there is no date fixed yet.

@OwenLu88
Copy link

I run an executable file after running pyinstaller. It reported, "Failed to execute script 'main' due to unhandled exception: No module named 'pyogrio._geometry'". Why is it?

@theroggy
Copy link
Member Author

I run an executable file after running pyinstaller. It reported, "Failed to execute script 'main' due to unhandled exception: No module named 'pyogrio._geometry'". Why is it?

I don't think this is related to this PR? Anyway, I'm not familiar with pyinstaller, so I'm afraid I cannot help you.

@OwenLu88
Copy link

I got it. Thanks.

@jorisvandenbossche
Copy link
Member

If you run into issues with pyinstaller, you can always open a new issue (although I am afraid that none of us is very familiar with it, but there might be others that have the same issue or can help)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG: integer overflow when reading int64 column
4 participants