Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid usage of packaging in non-test code #318

Merged
merged 2 commits into from
Oct 26, 2023

Conversation

jorisvandenbossche
Copy link
Member

See #316 (comment), this avoids adding it as an actual dependency.

Copy link
Member

@martinfleis martinfleis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As long as this is the only case of version checking I guess it is fine to do it manually like this. But if we'll need it on more occasions in future, I would just add packaging as a dependency. Given the low number of deps we have here, let's try it without but I am not sure how long it will take :).

Copy link
Member

@brendan-ward brendan-ward left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this also warrant a changelog entry for 0.7.1?

@brendan-ward brendan-ward merged commit b2d83eb into geopandas:main Oct 26, 2023
18 checks passed
@jorisvandenbossche jorisvandenbossche deleted the packaging-version branch October 27, 2023 07:18
@jorisvandenbossche
Copy link
Member Author

Sorry, this is really stupid. I just went from the error I saw on the conda-forge build, and didn't do a proper search for the usage of packaging, and we are also still using it in _compat.py ... and so 0.7.1 didn't fix the issue.

I suppose we then just add packaging to the dependencies?

@martinfleis
Copy link
Member

I suppose we then just add packaging to the dependencies?

That is probably the best option. We can revert this PR and add packaging as dependency here and then in meta on conda-forge.

@brendan-ward
Copy link
Member

Sorry, this is my fault for adding it to verify shapely / pandas versions; easy to overlook because our dev / test environments already have it.

I'll try to get a fix in place a bit later today.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants