Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: add some missing properties to read info #365

Conversation

theroggy
Copy link
Member

@theroggy theroggy commented Feb 26, 2024

Add some properties to read_info that I regularly use: layer_name, fid_column and geometry_name.

@theroggy theroggy marked this pull request as ready for review February 26, 2024 21:56
@brendan-ward brendan-ward added this to the 0.8.0 milestone Feb 28, 2024
Copy link
Member

@brendan-ward brendan-ward left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! A few suggestions...

pyogrio/_io.pyx Outdated Show resolved Hide resolved
pyogrio/_io.pyx Show resolved Hide resolved
pyogrio/_io.pyx Show resolved Hide resolved
pyogrio/core.py Outdated Show resolved Hide resolved
pyogrio/tests/test_core.py Outdated Show resolved Hide resolved
CHANGES.md Outdated Show resolved Hide resolved
pyogrio/tests/test_core.py Outdated Show resolved Hide resolved
pyogrio/_io.pyx Show resolved Hide resolved
CHANGES.md Outdated Show resolved Hide resolved
Copy link
Member

@brendan-ward brendan-ward left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @theroggy , apologies for the slow review!

@brendan-ward brendan-ward merged commit 22aaa7b into geopandas:main Apr 8, 2024
19 checks passed
@theroggy theroggy deleted the ENH-add-some-missing-properties-to-read_info branch April 9, 2024 05:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants