Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ENH: add on_invalid parameter to read_dataframe #422

Merged
merged 4 commits into from
Jun 17, 2024
Merged

ENH: add on_invalid parameter to read_dataframe #422

merged 4 commits into from
Jun 17, 2024

Conversation

theroggy
Copy link
Member

@theroggy theroggy commented Jun 13, 2024 •
edited
Loading

@theroggy theroggy mentioned this pull request Jun 13, 2024
Open
@theroggy theroggy marked this pull request as ready for review June 13, 2024 20:18
EwoutH
EwoutH reviewed Jun 14, 2024
View reviewed changes
Copy link
Contributor

@EwoutH EwoutH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for this PR, it looks good (from an outsiders perspective).

Would in the future this be extendable with something like a "repair" or "salvage" option?

@theroggy theroggy mentioned this pull request Jun 14, 2024
Open
@theroggy
Copy link
Member Author

theroggy commented Jun 14, 2024 •
edited
Loading

Would in the future this be extendable with something like a "repair" or "salvage" option?

I was starting to answer... but as there is no trivial solution, it's probably better to give this topic it's own issue: #423

brendan-ward
brendan-ward approved these changes Jun 14, 2024
View reviewed changes
Copy link
Member

@brendan-ward brendan-ward left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @theroggy !

@brendan-ward brendan-ward added this to the 0.9.0 milestone Jun 17, 2024
@theroggy theroggy mentioned this pull request Jun 17, 2024
Closed
@brendan-ward brendan-ward merged commit 0193d10 into geopandas:main Jun 17, 2024
20 checks passed
@theroggy theroggy deleted the ENH-add-on_invalid-parameter-to-read_dataframe branch June 17, 2024 19:00
@jorisvandenbossche jorisvandenbossche mentioned this pull request Jun 26, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EwoutH EwoutH EwoutH left review comments

@brendan-ward brendan-ward brendan-ward approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.9.0
Development

Successfully merging this pull request may close these issues.
3 participants
@theroggy @brendan-ward @EwoutH