Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR modifies the initialization of the starlette test client used in pygeoapi tests in order to comply with
the lastest changes introduced in starlette v0.35.0, specifically the merge of encode/starlette#2400
The change proposed in this PR is to not pass a
root_path
to the starlette test client, as the new starlette behavior is now to have mounted apps remove the root path when routing - since in the failing tests, which are checking the apirules functionality, pygeoapi is submounting routes under theurl_prefix
path.Related issue / discussion
Contributions and licensing
(as per https://github.com/geopython/pygeoapi/blob/master/CONTRIBUTING.md#contributions-and-licensing)