fix(mobile): prevent set budget amount zero (#346)

Resolves #322
get6pm · Sep 21, 2024 · a233ddb · a233ddb
1 parent a8e46bc
commit a233ddb
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 9 deletions.
diff --git a/apps/mobile/app/(app)/budget/[budgetId]/index.tsx b/apps/mobile/app/(app)/budget/[budgetId]/index.tsx
@@ -93,7 +93,7 @@ export default function BudgetDetailScreen() {
             push
           >
             <Button size="icon" variant="ghost">
-              <SettingsIcon className="size-6 text-primary" />
+              <SettingsIcon className="size-6 text-foreground" />
             </Button>
           </Link>
         </View>

diff --git a/apps/mobile/stores/budget/hooks.tsx b/apps/mobile/stores/budget/hooks.tsx
@@ -307,12 +307,15 @@ export function useBudgetPeriodStats(
 
   const remainingAmount = budgetAmount.add(totalBudgetUsage)
 
-  const usagePercentage = (
-    totalBudgetUsage.gt(0) ? new Decimal(0) : totalBudgetUsage.abs()
-  )
-    .div(budgetAmount!)
-    .mul(100)
-    .toNumber()
+  const usagePercentage = useMemo(() => {
+    if (budgetAmount.eq(0)) {
+      return 0
+    }
+    return (totalBudgetUsage.gt(0) ? new Decimal(0) : totalBudgetUsage.abs())
+      .div(budgetAmount!)
+      .mul(100)
+      .toNumber()
+  }, [totalBudgetUsage, budgetAmount])
 
   const averageAmountPerDay = budgetAmount.div(
     dayjsExtended(periodConfig?.endDate!).diff(

diff --git a/packages/validation/src/budget.zod.ts b/packages/validation/src/budget.zod.ts
@@ -15,7 +15,7 @@ export const zCreateBudget = z.object({
       amount: z
         .string({ coerce: true })
         .transform((val) => Number(`${val}`.replace(',', '.')))
-        .pipe(z.number({ coerce: true }).min(0))
+        .pipe(z.number({ coerce: true }).min(1))
         .optional(),
       startDate: z.date({ coerce: true }).optional(),
       endDate: z.date({ coerce: true }).optional(),
@@ -41,7 +41,7 @@ export const zUpdateBudget = z.object({
       amount: z
         .string({ coerce: true })
         .transform((val) => Number(`${val}`.replace(',', '.')))
-        .pipe(z.number({ coerce: true }).min(0))
+        .pipe(z.number({ coerce: true }).min(1))
         .optional(),
       startDate: z.date({ coerce: true }).optional(),
       endDate: z.date({ coerce: true }).optional(),