This repository has been archived by the owner on Aug 14, 2024. It is now read-only.
Add tracesSampler as source for sample_rate
#619
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Document internal discussion from Slack
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
untitaker
approved these changes
Jun 27, 2022
adinauer
commented
Jun 27, 2022
| @@ -115,7 +115,7 @@ The value of this envelope header is a JSON object with the following fields: | |||
|
|
|||
| - `trace_id` (string) - The original trace ID as generated by the SDK, UUID V4 encoded as a hexadecimal sequence with no dashes (e.g. `771a43a4192642f0b136d5159a501700`) that is a sequence of 32 hexadecimal digits. This must match the trace id of the submitted transaction item. | |||
| - `public_key` (string) - Public key from the DSN used by the SDK. It allows Sentry to sample traces spanning multiple projects, by resolving the same set of rules based on the starting project. | |||
| - `sample_rate` (string) - The sample rate as defined by the user on the SDK. This string should always be a number between (and including) 0 and 1 in basic float notation (`0.04242`) - no funky business like exponents or anything similar. | |||
| - `sample_rate` (string) - The sample rate as defined by the user on the SDK. This string should always be a number between (and including) 0 and 1 in basic float notation (`0.04242`) - no funky business like exponents or anything similar. If a `tracesSampler` callback was used for the sampling decision, its outcome should be used for `sample_rate` instead of the `tracesSampleRate` from `SentryOptions`. In case `tracesSampler` returns `True` it should be sent as `1.0`. | |||
There was a problem hiding this comment.
Should SDKs behave this way for LA release already?
mitsuhiko
approved these changes
Jun 27, 2022
Lms24
approved these changes
Jun 27, 2022
|
Do we want to define what a return value of |
Co-authored-by: Luca Forstner <luca.forstner@gmail.com>
I'd assume it means |
6 tasks
|
that sounds reasonable to me but i haven't thought it through |
AbhiPrasad
approved these changes
Jun 27, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Document internal discussion from Slack