Skip to content
This repository has been archived by the owner on Aug 14, 2024. It is now read-only.

feat(transactions): Add transaction_info.source [INGEST-1427] #624

Merged
merged 7 commits into from
Jul 4, 2022

Conversation

jjbayer
Copy link
Member

@jjbayer jjbayer commented Jun 30, 2022

Add a source label to every transaction that indicates how the transaction name was generated, as decided in https://www.notion.so/sentry/Annotating-Transaction-Names-a08a05ff97b348b0903de03a17baa731.

Rendered version is here and will be included on the "Transaction Type" page.

@vercel
Copy link

vercel bot commented Jun 30, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
develop ✅ Ready (Inspect) Visit Preview Jul 1, 2022 at 0:18AM (UTC)

@jjbayer jjbayer marked this pull request as ready for review June 30, 2022 07:23
Copy link
Member

@jan-auer jan-auer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we also update other places, such as:

@jjbayer
Copy link
Member Author

jjbayer commented Jun 30, 2022

Should we also update other places, such as:

@jan-auer I added a reference in "Guidelines for PM". Not sure about the Unified API, do you mean as a second parameter to set_transaction()? Would this not automatically become public API? I assume we want to prevent the user from setting the source themselves.

@jan-auer
Copy link
Member

jan-auer commented Jul 1, 2022

Redirecting this question to @AbhiPrasad. Would you expect "internal" APIs into the Unified API docs, for example the optional argument for setting a transaction with source?

Copy link
Member

@untitaker untitaker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should add this to the public docs, after all SDKs need to know how to send this

@untitaker untitaker changed the title feat(transactions): Add transaction_info.source feat(transactions): Add transaction_info.source [INGEST-1427] Jul 1, 2022
@jjbayer jjbayer merged commit 151ab50 into master Jul 4, 2022
@jjbayer jjbayer deleted the feat/transaction-source branch July 4, 2022 09:05
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants