-
-
Notifications
You must be signed in to change notification settings - Fork 225
feat(transactions): Add transaction_info.source [INGEST-1427] #624
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we also update other places, such as:
- Unified API: add the source as internal second parameter
- Guidelines for Performance Monitoring: Mention that the transaction source should be set.
@jan-auer I added a reference in "Guidelines for PM". Not sure about the Unified API, do you mean as a second parameter to |
Redirecting this question to @AbhiPrasad. Would you expect "internal" APIs into the Unified API docs, for example the optional argument for setting a transaction with source? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should add this to the public docs, after all SDKs need to know how to send this
Add a
source
label to every transaction that indicates how the transaction name was generated, as decided in https://www.notion.so/sentry/Annotating-Transaction-Names-a08a05ff97b348b0903de03a17baa731.Rendered version is here and will be included on the "Transaction Type" page.