-
-
Notifications
You must be signed in to change notification settings - Fork 225
Add transaction back to DSC specification #635
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is a good general description for "good quality" transaction names.
Wondering if the dependence for transaction
being added to the DSC on the transaction source should be a hard requirement instead of a suggestion. But as long as Relay doesn't make sampling decisions based on the source (which IIRC and according to the spec) I think we can leave this open to SDK implementors.
Co-authored-by: Lukas Stracke <lukas.stracke@sentry.io>
Good input! The reason I wrote it like this and also didn't make it a hard-requirement to have the transaction on the DSC based on transaction source, is because not all SDKs have the problem of "low quality transaction names" like the JS SDK with URLs and additionally not all SDKs will have to provide a transaction source until relay makes it required. |
Yeah, makes sense to leave it as is for now |
Co-authored-by: Joris Bayer <joris.bayer@sentry.io>
Resolves #634