fix(apis): Read from api schema repo #652
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sentaur-athena
commented
Oct 10, 2023
|
|
||
| const OWNERSHIP_FILE_PATH = | ||
| 'src/sentry/apidocs/api_ownership_stats_dont_modify.json'; | ||
| const OWNERSHIP_FILE_PATH = 'api_ownership_stats_dont_modify.json'; |
There was a problem hiding this comment.
Codecov ReportAll modified lines are covered by tests ✅
📢 Thoughts on this report? Let us know!. |
src/brain/apis/getOwnershipData.ts
Outdated
| const OWNERSHIP_FILE_PATH = | ||
| 'src/sentry/apidocs/api_ownership_stats_dont_modify.json'; | ||
| const OWNERSHIP_FILE_PATH = 'api_ownership_stats_dont_modify.json'; | ||
| const SENTRY_API_SCHEMA = 'sentry-api-schema' |
There was a problem hiding this comment.
Suggested change
| const SENTRY_API_SCHEMA = 'sentry-api-schema' | |
| const SENTRY_API_SCHEMA = 'sentry-api-schema'; |
Another option is to inline this. The only reason we have the SENTRY_REPO_SLUG constant is to make testing easier, but in this case, this is a constant and can be inlined in the getContent call.
mattgauntseo-sentry
approved these changes
Oct 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We decided that this file is better to live in sentry-api-schema repo. The file content is the same so the bot will behave the same.
Context for repo change: getsentry/sentry#56698