ref(metrics): Rename tag-field to tags #3006
Conversation
|
|
||
| ## 0.8.44 | ||
|
|
||
| - Add ability to block metrics matching a glob pattern. ([#2954](https://github.com/getsentry/relay/pull/2954)) |
There was a problem hiding this comment.
so this was added together with the 'various fixes and improvements', but this is more of a new feature. Not sure how to best retroactively add it
There was a problem hiding this comment.
You did it right IMO. "Various fixes & improvements" seems to be a bot thing.
| @@ -43,7 +43,7 @@ pub struct TagBlock { | |||
| /// Name of metric of which we want to remove certain tags. | |||
| pub name: GlobPatterns, | |||
There was a problem hiding this comment.
Shouldn't this also be "names" then?
There was a problem hiding this comment.
atm, we think of it as it should just be a single name pattern there, it's just the type we use allows for multiple. So, depends on if we should name after what we intend to do, or name after what we are able to do
|
|
||
| ## 0.8.44 | ||
|
|
||
| - Add ability to block metrics matching a glob pattern. ([#2954](https://github.com/getsentry/relay/pull/2954)) |
There was a problem hiding this comment.
You did it right IMO. "Various fixes & improvements" seems to be a bot thing.
It's a list, so the name should reflect that.
#skip-changelog