Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(replays): Add killswitch for mobile replays #3402

Merged
merged 13 commits into from
Apr 15, 2024

Conversation

cmanallen
Copy link
Member

@cmanallen cmanallen commented Apr 9, 2024

Organizations are not allowed unless the organizations:session-replay-video flag evaluates to true.

Related: getsentry/sentry#63255

Related PRs:
https://github.com/getsentry/getsentry/pull/13596/files
https://github.com/getsentry/sentry/pull/68567/files

@cmanallen cmanallen marked this pull request as ready for review April 9, 2024 20:43
@cmanallen cmanallen requested a review from a team as a code owner April 9, 2024 20:43
Copy link
Member

@jjbayer jjbayer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good to me, some test coverage would be nice.

Copy link
Contributor

@iker-barriocanal iker-barriocanal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving not to block on the option name, but please align the PR description with the code before merging.

relay-dynamic-config/src/feature.rs Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
@cmanallen cmanallen merged commit be342fb into master Apr 15, 2024
20 checks passed
@cmanallen cmanallen deleted the cmanallen/replays-mobile-add-killswitch branch April 15, 2024 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants